优化

firstleg/src/test/java/com/baiyue/firstleg/loading/service/LoadingDeliveryServiceTest.java

@@ -25,6 +25,7 @@ import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.springframework.http.ResponseEntity;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -197,6 +198,43 @@ class LoadingDeliveryServiceTest {
         verify(repository, never()).completeLoadedChild(10, 20, 7, 6);
     }
 
+    @Test
+    void pdaFinalizeResumesSameProcessingClaimLeftByAnEarlierWorkerFailure() {
+        readyForPdaFinalizeFacts();
+        CompletionTarget settled = new CompletionTarget(20L, null, 20L,
+            "LOADING", 7, "LOADING", 7);
+        when(repository.completionTarget(10, 20)).thenReturn(settled);
+        when(repository.findInboundForUpdate(10, 20)).thenReturn(new Snapshot(20L, 10L, "LOADING", 7));
+        when(repository.findInbound(10, 20)).thenReturn(new Snapshot(20L, 10L, "LOADING", 7));
+        when(repository.completeLoadedChild(10, 20, 7, 7)).thenReturn(1);
+        AtomicReference<String> hash = new AtomicReference<>();
+        when(repository.claimOperation(eq(10L), eq(20L), eq(7L), eq("COMPLETE_LOADING"),
+            eq("pda-resume"), anyString())).thenAnswer(invocation -> {
+                hash.set(invocation.getArgument(5));
+                return false;
+            });
+        when(repository.findOperation(10L, 20L, 7L, "COMPLETE_LOADING", "pda-resume"))
+            .thenAnswer(invocation -> processingOperation(hash.get()));
+
+        LoadingActionResponse result = service.completeAfterPdaSettlement(
+            10, 20, 7, "admin", "pda-resume", "完成");
+
+        assertThat(result.mainStatus()).isEqualTo("LOADED");
+        verify(repository).completeLoadedChild(10, 20, 7, 7);
+        verify(repository).completeOperation(eq(10L), eq(20L), eq(7L),
+            eq("COMPLETE_LOADING"), eq("pda-resume"), anyString());
+    }
+
+    @Test
+    void pdaFinalizeEntryPointsAreTransactional() throws Exception {
+        assertThat(LoadingDeliveryService.class.getMethod("completeAfterPdaSettlement",
+            long.class, long.class, long.class, String.class, String.class, String.class)
+            .getAnnotation(Transactional.class)).isNotNull();
+        assertThat(LoadingDeliveryService.class.getMethod("completeAfterPdaSettlement",
+            long.class, long.class, long.class, long.class, String.class, String.class, String.class)
+            .getAnnotation(Transactional.class)).isNotNull();
+    }
+
     @Test
     void pdaFinalizeLocksAndUsesLoadedSliceVersionAfterPartialSettlement() {
         readyForPdaFinalize();
@@ -436,11 +474,16 @@ class LoadingDeliveryServiceTest {
     private void readyForPdaFinalize() {
         when(repository.claimOperation(anyLong(), anyLong(), anyLong(), anyString(), anyString(), anyString()))
             .thenReturn(true);
+        readyForPdaFinalizeFacts();
+    }
+
+    private void readyForPdaFinalizeFacts() {
         LoadingPickItemMapper.InboundProgress progress = mock(LoadingPickItemMapper.InboundProgress.class);
         when(progress.getExpectedCount()).thenReturn(5);
         when(progress.getPickedCount()).thenReturn(5);
         when(progress.getTaskCount()).thenReturn(1);
-        when(progress.getCompletedTaskCount()).thenReturn(1);
+        // completion worker runs before task finalization; accepted COMPLETING is not COMPLETED yet.
+        when(progress.getCompletedTaskCount()).thenReturn(0);
         when(progress.getUnresolvedCount()).thenReturn(0);
         when(loadingPicks.inboundProgress(10, 20)).thenReturn(progress);
         when(repository.listEvidence(10, 20)).thenReturn(List.of(
@@ -462,4 +505,11 @@ class LoadingDeliveryServiceTest {
         value.setResultJson(resultJson);
         return value;
     }
+
+    private static LoadingOperationEntity processingOperation(String requestHash) {
+        LoadingOperationEntity value = new LoadingOperationEntity();
+        value.setRequestHash(requestHash);
+        value.setStatus("PROCESSING");
+        return value;
+    }
 }